Shaper of Storm + Shaper of Winter - Questions

So as i read it, both talents work based on Hits.
So it works for Attacks right?

So if i would use something like an explosive shot, doing 80 physical and 20 fire damage,

100 damage would be considered for the shock chance and for the chill magnitude?


I searched for answers on the internet and did not find much, does this imply that it is a stupid idea and should not be pursued?