Global Shaper crit mod not working as intended?

Bug Report ID: #184271927

I'm not 100% sure its working as intended, but per how it reads it should work.
issue i am having is that the global shaper mod "+#% to Spell Critical Strike Chance" on a chest piece do not affect Herald of Ice, or Herald of Thunder,(global mod does interact and gives crit to other spells like flame dash)
BUT both the Essence of Horror mod from gloves "Socketed Gems have +3.5% Critical Strike Chance" AND shaper mod "Socketed Spells have +3% to Critical Strike Chance" do work with herald of ice and herald of thunder when socketed into the items,

HoI,HoT, do get crit and can scale crit with with global modifiers of crit like the support gem increased critical strike chance or a dagger(implicit), but do not scale with increased spell critical strike chance from like a scepter
both heralds do have the "Spell" tag

Is the Interactions of herald of ice/thunder working as intended? several of the interactions reads as they should work
its mostly the mod "Socketed Spells have +3% to Critical Strike Chance" actually affecting the herald socketed, but other spell specific mods like the global shaper chest mod, and global vs spell crit after getting base crit on the herald that brings the question if it all works as intended or if there is some bugged interactions involved

items and highlighted modifiers below

Item Class: Helmets
Rarity: Rare
Golem Corona
Noble Tricorne
--------
Evasion Rating: 315 (augmented)
--------
Requirements:
Level: 67
Dex: 99
Int: 84
--------
Sockets: B-B-G-G
--------
Item Level: 85
--------
Socketed Gems are Supported by Level 20 Increased Area of Effect
Socketed Spells have +3% to Critical Strike Chance
+60 to Evasion Rating
+29 to maximum Life
55% increased Mana Regeneration Rate
15% increased Area of Effect
+54 to maximum Life (crafted)
--------
Shaper Item


Item Class: Gloves
Rarity: Rare
Hate Touch
Crusader Gloves
--------
Armour: 294 (augmented)
Energy Shield: 77 (augmented)
Memory Strands: 56
--------
Requirements:
Level: 66
Str: 51
Dex: 84
Int: 146
--------
Sockets: G-B-B-B
--------
Item Level: 85
--------
Socketed Gems have +3.5% Critical Strike Chance
Adds 4 to 9 Physical Damage to Attacks
14% increased Attack Speed
+74 to Armour
+27 to maximum Energy Shield
+39% to Cold Resistance
49% increased Armour and Energy Shield (crafted)


Item Class: Body Armours
Rarity: Rare
Kraken Sanctuary
Torturer Garb
--------
Quality: +20% (augmented)
Evasion Rating: 1114 (augmented)
Energy Shield: 273 (augmented)
--------
Requirements:
Level: 78
Dex: 151
Int: 151
--------
Sockets: G B-G-G-G G
--------
Item Level: 86
--------
Socketed Gems are Supported by Level 15 Item Rarity
+28 to maximum Energy Shield
+163 to maximum Life
Regenerate 37.5 Life per second
+1.17% to Spell Critical Strike Chance
16% increased Rarity of Items found from Slain Unique Enemies
46% increased Evasion and Energy Shield (crafted)
--------
Shaper Item

"

stian992#4502 wrote:

Is the Interactions of herald of ice/thunder working as intended?

Yes, it is.

While Herald of Ice and Herald of Thunder are Spell skills, the shatter explosions and lightning storm strikes are not treated as spell hits--which is why the last line of the gems' green description text says "this damage is not affected by modifiers to spell damage".

Skills like Blight have a modifier/property shown in blue stating that their damage over time is affected by modifiers to spell damage, because damage over time is inherently not spell damage. Herald of Ice/Thunder don't have such a modifier, because the skill is not making a spell hit that is unaffected by spell damage, but making a hit that is not a spell hit in the first place.

The "Socketed Spells have +3% to Critical Strike Chance" modifier can give Crit Chance to these hits because the Herald skill itself is a spell, and the Crit Chance being given isn't exclusively for spell hits. That modifier would be just as effective for the explosion portion of Detonate Dead, for example.